Skip to content

Keep doctor metadata guard aligned with repair-path refactors#233

Closed
NagyVikt wants to merge 1 commit intomainfrom
agent/codex/fix-doctor-repair-path-metadata-test-2026-04-21-14-51
Closed

Keep doctor metadata guard aligned with repair-path refactors#233
NagyVikt wants to merge 1 commit intomainfrom
agent/codex/fix-doctor-repair-path-metadata-test-2026-04-21-14-51

Conversation

@NagyVikt
Copy link
Copy Markdown
Collaborator

Summary

  • stop pinning the doctor repair-path metadata assertion to a specific local variable name
  • keep the guard focused on the real contract: , , and a option

Verification

  • node --test test/metadata.test.js
  • node --test test/merge-workflow.test.js
  • node --check bin/multiagent-safety.js

The metadata suite was pinning the exact local variable name passed to the Doctor/fix dry-run renderer. The CLI now uses a different option binding, so the assertion was failing even though the repair-first path still executed the same contract.\n\nThis narrows the source guard to the behavior that matters: the doctor command remains single-source and still forwards the Doctor/fix payload together with a dry-run flag.

Constraint: The regression test must keep protecting the repair-first doctor path without forcing a cosmetic local variable name.\nRejected: Rename the CLI variable back to singleRepoOptions | needless churn in production code for a test-only mismatch\nConfidence: high\nScope-risk: narrow\nReversibility: clean\nDirective: Keep metadata assertions focused on behavioral contracts rather than ephemeral local identifier names.\nTested: node --test test/metadata.test.js\nTested: node --test test/merge-workflow.test.js\nTested: node --check bin/multiagent-safety.js\nNot-tested: full npm test suite
@NagyVikt
Copy link
Copy Markdown
Collaborator Author

Closing as superseded by main via #234 (commit bcecd9c). The current metadata-test expectation on main already covers this repair path, so this PR no longer carries unique changes.

@NagyVikt NagyVikt closed this Apr 21, 2026
@NagyVikt NagyVikt deleted the agent/codex/fix-doctor-repair-path-metadata-test-2026-04-21-14-51 branch April 21, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant