Keep doctor metadata guard aligned with repair-path refactors#233
Closed
Keep doctor metadata guard aligned with repair-path refactors#233
Conversation
The metadata suite was pinning the exact local variable name passed to the Doctor/fix dry-run renderer. The CLI now uses a different option binding, so the assertion was failing even though the repair-first path still executed the same contract.\n\nThis narrows the source guard to the behavior that matters: the doctor command remains single-source and still forwards the Doctor/fix payload together with a dry-run flag. Constraint: The regression test must keep protecting the repair-first doctor path without forcing a cosmetic local variable name.\nRejected: Rename the CLI variable back to singleRepoOptions | needless churn in production code for a test-only mismatch\nConfidence: high\nScope-risk: narrow\nReversibility: clean\nDirective: Keep metadata assertions focused on behavioral contracts rather than ephemeral local identifier names.\nTested: node --test test/metadata.test.js\nTested: node --test test/merge-workflow.test.js\nTested: node --check bin/multiagent-safety.js\nNot-tested: full npm test suite
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification